Fix creating a lot of ephemeral ports when stopping GlassFish. Fix restart on fast machines #25300
+538
−303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The start succeeded too early and on fast machines collided with shutdown. - Shutdown Hook is really the last thing in the JVM capable of doing it. - All shutdown hooks have names now Signed-off-by: David Matějček <[email protected]>
…cases - when current (old) JVM had enabled debugging, the new one sometimes failed to start. It is not possible to wait from the inside. - Stop the kernell after adding the last shutdown hook; shutdown hooks run in parallel, but we have to ensure that ours will be executed after all other non-daemon hooks finish. - export AS_RESTART_LOGFILES=true to get "old" and "new" files in the server's log directory. It is trivial workaround, because the standard logging system might get into a conflict with the new GF instance too. - The "super debug" is not helpful as it affects timing Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- its only usage was for the domain restart which was reimplemented Signed-off-by: David Matějček <[email protected]>
- backup of the server.log cannot be done if the server is dead - Using System.Logger instead of JUL Signed-off-by: David Matějček <[email protected]>
- Original code caused local port exhaustion - Original code used busy spinning instead of signals Signed-off-by: David Matějček <[email protected]>
dmatej
force-pushed
the
fix-restart-on-fast-machines
branch
14 times, most recently
from
24b4717 to
3c040b2
Compare
|
Heuréka! And now I see why we had that weird code checking of |
- Reverted usage of ProcessHandle.onExit.get as it doesn't work in containers which don't have strict reaper. The zombie project is considered as alive and get then hangs forever. - Added waitpid, however it is not installed everywhere - if it is missing, we sleep for 1 second instead. That should be enough so the operating system could do the cleanup. Signed-off-by: David Matějček <[email protected]>
dmatej
force-pushed
the
fix-restart-on-fast-machines
branch
from
3c040b2 to
190fd0b
Compare
avpinchuk
reviewed
Dec 29, 2024
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/StartServerHook.java
Show resolved
Hide resolved
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/StartServerHook.java
Show resolved
Hide resolved
OndroMih
approved these changes
Dec 29, 2024
OndroMih
changed the title
|
I renamed this PR so that it reflects all things that were fixed. The title will appear in the release notes so it's good if it clearly describes all that this PR adds/fixes. |
avpinchuk
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25295 and #25292
Replaces #25293
There were several issues, see individual commits. The main problem was that the startup can be faster than shutdown and then they could collide on ports and files. The most problematic was the debug port which is enabled since the JVM startup until the very end.
On my new machine it was reproducible in some 80% of executions.
Solution for #25292:
For #25295 was needed also
export AS_RESTART_LOGFILES=true;Note
handle#isAlivereturns true andonExit.getis still blocked.